Temporarily disable use_default_lucene_postings_format feature flag. #128253
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the feature flag was enabled, there were many changes happening at the same time. Upgrade to Lucene 10.2 and enabling logsdb by default. The new default codec did have a regression, that was fixed in Lucene with the next bugfix release (apache/lucene#14445). However, there's been still some noise in the benchmark since standard index mode started to use the default lucene posting format. By temporarily disabling and then enabling after a few days, we hope to get more clarity about whether there is still a regression.
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the feature flag was enabled, there were many changes happening at the same time. Upgrade to Lucene 10.2 and enabling logsdb by default. The new default codec did have a regression, that was fixed in Lucene with the next bugfix release (apache/lucene#14445).
However, there's been still some noise in the benchmark since standard index mode started to use the default lucene posting format. By temporarily disabling and then enabling after a few days, we hope to get more clarity about whether there is still a regression. I plan to revert this change Monday morning.